Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix abci::Code parser to accept a string or an int #13

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Fix abci::Code parser to accept a string or an int #13

merged 1 commit into from
Aug 14, 2019

Conversation

amanusk
Copy link
Contributor

@amanusk amanusk commented Aug 14, 2019

Addresses issue #10
Added tests for both cases

@amanusk
Fix abci::Code parser to accept a string or an int
a3ae5c8 
Addresses issue informalsystems#10
Added tests for both cases

Signed-off-by: amanusk <amanusk@protonmail.com>
@amanusk
Copy link
Contributor Author

amanusk commented Aug 14, 2019

@tarcieri,
Thanks, didn't consider the option of parsing both cases.
Added implementation inspired by this.

Not sure error handling is correct.

Also added a test for both cases

@tarcieri tarcieri merged commit f792231 into informalsystems:master Aug 14, 2019
@amanusk amanusk mentioned this pull request Aug 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanusk @tarcieri